Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with Tensorflow version #159

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fixed issues with Tensorflow version #159

merged 2 commits into from
Aug 7, 2024

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Aug 6, 2024 •
edited
Loading

Workers argument has been removed from keras fit function. Also, the newest version of keras requires specifying metrics for each output (instead of a single metric to be applied to all). Updated LSTM to support this. Closes #158

@teubert teubert requested a review from kjjarvis August 6, 2024 23:51
@teubert teubert added bug Something isn't working components: data model project: SWS System Wide Safety Project labels Aug 6, 2024
@teubert teubert linked an issue Aug 6, 2024 that may be closed by this pull request
Keras version - workers #158
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@teubert teubert changed the title Removed workers as argument Fixed issues with Tensorflow version Aug 7, 2024
kjjarvis
kjjarvis approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Tests run

@teubert teubert merged commit 1bc324f into dev Aug 7, 2024
28 of 30 checks passed
@teubert teubert deleted the bugs/158-keras-version-workers branch August 7, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjjarvis kjjarvis kjjarvis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working components: data model project: SWS System Wide Safety Project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keras version - workers
2 participants
@teubert @kjjarvis